Don't try to clone uri's without a corresponding destination
The code throws the exception undefined method `join' for nil:NilClass if destionation doesn't exist - so it's better to not call git_clone if destination is not present.
This commit is contained in:
@@ -27,12 +27,11 @@ class Homesick < Thor
|
|||||||
elsif uri =~ GITHUB_NAME_REPO_PATTERN
|
elsif uri =~ GITHUB_NAME_REPO_PATTERN
|
||||||
destination = Pathname.new($1)
|
destination = Pathname.new($1)
|
||||||
git_clone "git://github.com/#{$1}.git", :destination => destination
|
git_clone "git://github.com/#{$1}.git", :destination => destination
|
||||||
else
|
elsif uri =~ /\/([^\/]*)(\.git)?\Z/
|
||||||
if uri =~ /\/([^\/]*).git\Z/
|
destination = Pathname.new($1)
|
||||||
destination = Pathname.new($1)
|
|
||||||
end
|
|
||||||
|
|
||||||
git_clone uri
|
git_clone uri
|
||||||
|
else
|
||||||
|
raise "Unknown URI format: #{uri}"
|
||||||
end
|
end
|
||||||
|
|
||||||
if destination.join('.gitmodules').exist?
|
if destination.join('.gitmodules').exist?
|
||||||
|
|||||||
@@ -34,6 +34,24 @@ describe Homesick do
|
|||||||
@homesick.clone 'http://github.com/technicalpickles/pickled-vim.git'
|
@homesick.clone 'http://github.com/technicalpickles/pickled-vim.git'
|
||||||
end
|
end
|
||||||
|
|
||||||
|
it "should clone git repo like http://host/path/to" do
|
||||||
|
@homesick.should_receive(:git_clone).with('http://github.com/technicalpickles/pickled-vim')
|
||||||
|
|
||||||
|
@homesick.clone 'http://github.com/technicalpickles/pickled-vim'
|
||||||
|
end
|
||||||
|
|
||||||
|
it "should not try to clone a malformed uri like malformed" do
|
||||||
|
@homesick.should_not_receive(:git_clone)
|
||||||
|
|
||||||
|
@homesick.clone 'malformed' rescue nil
|
||||||
|
end
|
||||||
|
|
||||||
|
it "should throw an exception when trying to clone a malformed uri like malformed" do
|
||||||
|
lambda {
|
||||||
|
@homesick.clone 'malformed'
|
||||||
|
}.should raise_error
|
||||||
|
end
|
||||||
|
|
||||||
it "should clone a github repo" do
|
it "should clone a github repo" do
|
||||||
@homesick.should_receive(:git_clone).with('git://github.com/wfarr/dotfiles.git', :destination => Pathname.new('wfarr/dotfiles'))
|
@homesick.should_receive(:git_clone).with('git://github.com/wfarr/dotfiles.git', :destination => Pathname.new('wfarr/dotfiles'))
|
||||||
|
|
||||||
|
|||||||
Reference in New Issue
Block a user