From 92dc611bb15fe02733b8e7d5982c7b1d696fbc0b Mon Sep 17 00:00:00 2001 From: John Bellone Date: Fri, 21 Jun 2013 09:45:26 -0300 Subject: [PATCH 1/2] Update homesick.rb to make https default for GitHub clones. If we use HTTPS it is a lot easier for corporate worlds to manage proxies since its usually already done for us. Also HTTPS cloning is just as fast as the git protocol as of more recent versions. --- lib/homesick.rb | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/homesick.rb b/lib/homesick.rb index e1a7ebb..19d0dbe 100644 --- a/lib/homesick.rb +++ b/lib/homesick.rb @@ -32,7 +32,7 @@ class Homesick < Thor ln_s uri, destination elsif uri =~ GITHUB_NAME_REPO_PATTERN destination = Pathname.new($1) - git_clone "git://github.com/#{$1}.git", :destination => destination + git_clone "https://github.com/#{$1}.git", :destination => destination elsif uri =~ /%r([^%r]*?)(\.git)?\Z/ destination = Pathname.new($1) git_clone uri From 3d59bc7a972c62af3f0f86c2afec7105866e4f8e Mon Sep 17 00:00:00 2001 From: John Bellone Date: Wed, 17 Jul 2013 07:28:39 -0400 Subject: [PATCH 2/2] Update specs to for change to https vs. git protocol. --- spec/homesick_spec.rb | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/spec/homesick_spec.rb b/spec/homesick_spec.rb index dcc167b..2f58007 100644 --- a/spec/homesick_spec.rb +++ b/spec/homesick_spec.rb @@ -78,7 +78,7 @@ describe 'homesick' do end it 'should clone a github repo' do - homesick.should_receive(:git_clone).with('git://github.com/wfarr/dotfiles.git', :destination => Pathname.new('wfarr/dotfiles')) + homesick.should_receive(:git_clone).with('https://github.com/wfarr/dotfiles.git', :destination => Pathname.new('wfarr/dotfiles')) homesick.clone 'wfarr/dotfiles' end