aether/gosick
2
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Refactor the ln_s method to decrease its cyclomatic complexity

Browse Source
This commit is contained in:
Nicolas McCurdy
2014-01-07 20:12:53 -05:00
parent 7e659f11fe
commit e42eff4e10
3 changed files with 11 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
.rubocop.yml
View File

@@ -10,7 +10,7 @@ ClassLength:
Enabled: false Enabled: false
CyclomaticComplexity: CyclomaticComplexity:
Max: 9 Max: 7
LineLength: LineLength:
Max: 163 Max: 163

4
lib/homesick.rb
View File

@@ -387,6 +387,10 @@ class Homesick < Thor
first_p.mtime > second_p.mtime && !first_p.symlink? first_p.mtime > second_p.mtime && !first_p.symlink?
end end
def collision_accepted?
options[:force] || shell.file_collision(destination) { source }
end
def each_file(castle, basedir, subdirs) def each_file(castle, basedir, subdirs)
absolute_basedir = Pathname.new(basedir).expand_path absolute_basedir = Pathname.new(basedir).expand_path
inside basedir do inside basedir do

10
lib/homesick/actions.rb
View File

@@ -148,18 +148,16 @@ class Homesick
destination = Pathname.new(destination) destination = Pathname.new(destination)
FileUtils.mkdir_p destination.dirname FileUtils.mkdir_p destination.dirname
if destination.symlink? if destination.symlink? && destination.readlink == source
if destination.readlink == source
say_status :identical, destination.expand_path, :blue unless options[:quiet] say_status :identical, destination.expand_path, :blue unless options[:quiet]
else elsif destination.symlink?
say_status :conflict, "#{destination} exists and points to #{destination.readlink}", :red unless options[:quiet] say_status :conflict, "#{destination} exists and points to #{destination.readlink}", :red unless options[:quiet]
system "ln -nsf '#{source}' '#{destination}'" if (options[:force] || shell.file_collision(destination) { source }) && !options[:pretend] smart_system "ln -nsf '#{source}' '#{destination}'" if collision_accepted?
end
elsif destination.exist? elsif destination.exist?
say_status :conflict, "#{destination} exists", :red unless options[:quiet] say_status :conflict, "#{destination} exists", :red unless options[:quiet]
if options[:force] || shell.file_collision(destination) { source } if collision_accepted?
system "rm -rf '#{destination}'" unless options[:pretend] system "rm -rf '#{destination}'" unless options[:pretend]
system "ln -sf '#{source}' '#{destination}'" unless options[:pretend] system "ln -sf '#{source}' '#{destination}'" unless options[:pretend]
end end