aether/gosick
2
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Merge pull request #172 from rbalint/master

Browse Source 
Fix tests on Ruby 2.5
This commit is contained in:
Jeremy Cook
2018-03-08 06:37:30 -05:00
committed by GitHub
parent c2457bae9f dcef34c17d
commit e561566b46
2 changed files with 5 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
.travis.yml
View File

@@ -1,5 +1,6 @@
language: ruby language: ruby
rvm: rvm:
- 2.5.0
- 2.4.0 - 2.4.0
- 2.3.3 - 2.3.3
- 2.2.6 - 2.2.6

4
spec/homesick_cli_spec.rb
View File

@@ -739,6 +739,8 @@ describe Homesick::CLI do
end end
it 'returns an error message when the $EDITOR environment variable is not set' do it 'returns an error message when the $EDITOR environment variable is not set' do
# Return empty ENV, the test does not call it anyway
allow(ENV).to receive(:[]).and_return(nil)
# Set the default editor to make sure it fails. # Set the default editor to make sure it fails.
allow(ENV).to receive(:[]).with('EDITOR').and_return(nil) allow(ENV).to receive(:[]).with('EDITOR').and_return(nil)
expect(homesick).to receive('say_status').once expect(homesick).to receive('say_status').once
@@ -747,6 +749,8 @@ describe Homesick::CLI do
end end
it 'returns an error message when the given castle does not exist' do it 'returns an error message when the given castle does not exist' do
# Return empty ENV, the test does not call it anyway
allow(ENV).to receive(:[]).and_return(nil)
# Set a default just in case none is set # Set a default just in case none is set
allow(ENV).to receive(:[]).with('EDITOR').and_return('vim') allow(ENV).to receive(:[]).with('EDITOR').and_return('vim')
allow(homesick).to receive('say_status').once allow(homesick).to receive('say_status').once