From 6a83abe4dbabd0567c2266291bdf887fc9e0538c Mon Sep 17 00:00:00 2001 From: Micheal Wilkinson Date: Fri, 20 Mar 2026 23:51:57 +0000 Subject: [PATCH] test: cover base URL repository override --- internal/vociferate/vociferate_internal_test.go | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/internal/vociferate/vociferate_internal_test.go b/internal/vociferate/vociferate_internal_test.go index 27aa2f4..2b8b0d8 100644 --- a/internal/vociferate/vociferate_internal_test.go +++ b/internal/vociferate/vociferate_internal_test.go @@ -16,7 +16,9 @@ func TestNormalizeRepoURL(t *testing.T) { wantOK bool }{ {name: "https", remoteURL: "https://git.hrafn.xyz/aether/vociferate.git", wantURL: "https://git.hrafn.xyz/aether/vociferate", wantOK: true}, + {name: "https trailing slash", remoteURL: "https://git.hrafn.xyz/aether/vociferate/", wantURL: "https://git.hrafn.xyz/aether/vociferate", wantOK: true}, {name: "http", remoteURL: "http://teapot:3000/aether/vociferate.git", wantURL: "http://teapot:3000/aether/vociferate", wantOK: true}, + {name: "http trailing slash", remoteURL: "http://teapot:3000/aether/vociferate/", wantURL: "http://teapot:3000/aether/vociferate", wantOK: true}, {name: "ssh with scheme", remoteURL: "ssh://git@git.hrafn.xyz/aether/vociferate.git", wantURL: "https://git.hrafn.xyz/aether/vociferate", wantOK: true}, {name: "scp style", remoteURL: "git@git.hrafn.xyz:aether/vociferate.git", wantURL: "https://git.hrafn.xyz/aether/vociferate", wantOK: true}, {name: "empty", remoteURL: "", wantURL: "", wantOK: false}, @@ -123,7 +125,7 @@ func TestDeriveRepositoryURLFromGitConfigFallback(t *testing.T) { } func TestDeriveRepositoryURL_UsesOverrideAsHighestPriority(t *testing.T) { - t.Setenv("VOCIFERATE_REPOSITORY_URL", "https://git.hrafn.xyz/aether/vociferate") + t.Setenv("VOCIFERATE_REPOSITORY_URL", "https://git.hrafn.xyz/git") t.Setenv("GITHUB_SERVER_URL", "http://teapot:3000") t.Setenv("GITHUB_REPOSITORY", "aether/vociferate") @@ -140,7 +142,7 @@ func TestDeriveRepositoryURL_UsesOverrideAsHighestPriority(t *testing.T) { if !ok { t.Fatal("expected repository URL from override") } - if url != "https://git.hrafn.xyz/aether/vociferate" { + if url != "https://git.hrafn.xyz/git/aether/vociferate" { t.Fatalf("unexpected repository URL: %q", url) } }